Re: [PATCH 2/5] net: add an info message to eth_platform_get_mac_address()

From: David Miller
Date: Wed Jul 18 2018 - 19:13:05 EST


From: Bartosz Golaszewski <brgl@xxxxxxxx>
Date: Wed, 18 Jul 2018 18:10:32 +0200

>
> + dev_info(dev, "read MAC address from %s\n", from);
> ether_addr_copy(mac_addr, addr);
> return 0;

Ugh, please don't do this.

We probe various bits of information from various sources during
driver probe, and none of them are more or less important than
the MAC address. So singling this out for log info output is
really not such a great idea.

Thank you.