Re: [PATCH] ipv6: sr: fix useless rol32 call on hash

From: David Miller
Date: Wed Jul 18 2018 - 18:11:50 EST


From: Colin King <colin.king@xxxxxxxxxxxxx>
Date: Tue, 17 Jul 2018 16:52:54 +0100

> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> The rol32 call is currently rotating hash but the rol'd value is
> being discarded. I believe the current code is incorrect and hash
> should be assigned the rotated value returned from rol32.
>
> Detected by CoverityScan, CID#1468411 ("Useless call")
>
> Fixes: b5facfdba14c ("ipv6: sr: Compute flowlabel for outer IPv6 header of seg6 encap mode")
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>

Applied and queued up for -stable.