Re: [PATCH 4/5] mtd: rawnand: qcom: update BBT related flags

From: Boris Brezillon
Date: Wed Jul 18 2018 - 17:36:41 EST


On Wed, 18 Jul 2018 23:15:26 +0200
Miquel Raynal <miquel.raynal@xxxxxxxxxxx> wrote:

> Hi Abhishek,
>
> Abhishek Sahu <absahu@xxxxxxxxxxxxxx> wrote on Fri, 6 Jul 2018
> 13:21:58 +0530:
>
> > Remove the NAND_SKIP_BBTSCAN to use RAM based BBT.
>
> Unless I am understanding it the wrong way, NAND_SKIP_BBTSCAN will skip
> the scan of the on-chip BBT and will scan every block to construct a
> RAM, based BBT thanks to the BBM.
>
> So flash based BBT is already unused and removing this flag is a
> mistake, right?

->scan_bbt() is also taking care of building the in-RAM BBT based on
BBM when no on-flash BBT is provided, so I think it's the right thing
to do.

>
> > Flash based BBT is not used since bootloaders
> > doesn't have support for the same.
> >
> > Signed-off-by: Abhishek Sahu <absahu@xxxxxxxxxxxxxx>
> > ---
>
> Thanks,
> MiquÃl
>