Re: [PATCH] pktcdvd:checkpatch:fix pointer declaration

From: Bart Van Assche
Date: Wed Jul 18 2018 - 14:06:48 EST


On Wed, 2018-07-18 at 21:28 +-0530, RAGHU Halharvi wrote:
+AD4- +ACo- Fix all pointer declaration which causes
+AD4- +ACI-ERROR: +ACI-foo+ACo- bar+ACI- should be +ACI-foo +ACo-bar+ACIAIg-

Hello Raghu,

If you would not be aware of this, checkpatch is a tool that is intended to
verify patches before submission and not to verify code that is already
upstream. A detailed explanation of why patches like this one should not be
submitted is available in +ACI-A quick guide to why stand-alone checkpatch
patches suck+ACI-
(https://lists.kernelnewbies.org/pipermail/kernelnewbies/2014-September/012296.html).

Thanks,

Bart.