Re: [PATCH v2] nand: ranw: qcom_nand: stop using phys_to_dma()

From: Miquel Raynal
Date: Wed Jul 18 2018 - 03:48:12 EST


Hi Boris,

Boris Brezillon <boris.brezillon@xxxxxxxxxxx> wrote on Tue, 17 Jul 2018
22:33:59 +0200:

> On Tue, 17 Jul 2018 22:27:42 +0200
> Arnd Bergmann <arnd@xxxxxxxx> wrote:
>
> > Compile-testing this driver on x86 caused a link error:
> >
> > ERROR: "__phys_to_dma" [drivers/mtd/nand/raw/qcom_nandc.ko] undefined!
> >
> > The problem here is that the driver attempts to convert the physical
> > address into the DMA controller as a dma_addr_t and calls phys_to_dma()
> > to do the conversion.
> >
> > The correct way to do the conversion is using the dma mapping interfaces.
> >
> > Fixes: c76b78d8ec05 ("mtd: nand: Qualcomm NAND controller driver")
> > Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
>
> Reviewed-by: Boris Brezillon <boris.brezillon@xxxxxxxxxxx>
>
> Miquel, can you fix the subject prefix when applying?

Applied to nand/next with the subject prefix being:
"mtd: rawnand: qcom:"

Thanks
MiquÃl