Re: [PATCH] lib/rhashtable: consider param->min_size when setting initial table size

From: Davidlohr Bueso
Date: Tue Jul 17 2018 - 18:31:07 EST


On Mon, 16 Jul 2018, Herbert Xu wrote:

On Fri, Jul 13, 2018 at 11:25:16PM -0700, Davidlohr Bueso wrote:
rhashtable_init() currently does not take into account the user-passed
min_size parameter unless param->nelem_hint is set as well. As such,
the default size (number of buckets) will always be HASH_DEFAULT_SIZE
even if the smallest allowed size is larger than that. Remediate this
by unconditionally calling into rounded_hashtable_size() and handling
things accordingly.

Signed-off-by: Davidlohr Bueso <dbueso@xxxxxxx>

Acked-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>

Normally these patches go through netdev so could you please resend
it with my ack to netdev@xxxxxxxxxxxxxxx?

So I've done the resend, but at least would think that routing the
patch through Andrew would work best as he picked up the rhashtable
changes regarding ipc and this touches the same call.

Thanks,
Davidlohr