RE: [PATCH v9 07/10] firmware: xilinx: Add debugfs for IOCTL API

From: Jolly Shah
Date: Tue Jul 17 2018 - 16:01:48 EST


Hi Stephen,

Thanks for the review,

> -----Original Message-----
> From: Stephen Boyd [mailto:sboyd@xxxxxxxxxx]
> Sent: Sunday, July 08, 2018 10:29 PM
> To: Jolly Shah <JOLLYS@xxxxxxxxxx>; ard.biesheuvel@xxxxxxxxxx;
> dmitry.torokhov@xxxxxxxxx; gregkh@xxxxxxxxxxxxxxxxxxx;
> hkallweit1@xxxxxxxxx; keescook@xxxxxxxxxxxx; linux-clk@xxxxxxxxxxxxxxx;
> mark.rutland@xxxxxxx; matt@xxxxxxxxxxxxxxxxxxx; Michal Simek
> <michals@xxxxxxxxxx>; mingo@xxxxxxxxxx; mturquette@xxxxxxxxxxxx;
> robh+dt@xxxxxxxxxx; sboyd@xxxxxxxxxxxxxx; sudeep.holla@xxxxxxx
> Cc: Rajan Vaja <RAJANV@xxxxxxxxxx>; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx;
> linux-kernel@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; Jolly Shah
> <JOLLYS@xxxxxxxxxx>
> Subject: Re: [PATCH v9 07/10] firmware: xilinx: Add debugfs for IOCTL API
>
> Quoting Jolly Shah (2018-06-20 10:40:32)
> > From: Rajan Vaja <rajanv@xxxxxxxxxx>
> >
> > Add debugfs file to set/get IOCTL using debugfs interface.
>
> IOCTLs and debugfs aren't the same thing. Why are the two being mixed
> together? Is some sort of userspace ABI being created here to control clks with
> usermode drivers?

This is not standard ioctl. This is type of ZynqMP API just like other APIs. This debugfs is created to debug ZynqMP IOCTL API.

Thanks,
Jolly Shah