Re: [PATCH 0/5] Add support for MSCC Ocelot i2c

From: Andy Shevchenko
Date: Tue Jul 17 2018 - 08:21:36 EST


On Tue, 2018-07-17 at 13:48 +0200, Alexandre Belloni wrote:
> Hi,
>
> Because the designware IP was not able to the the SDA hold time, MSCC
> has
> its own implementation. Add support for it and then add i2c on ocelot
> boards.
>
> I would expect patches 1 to 3 to go through the i2c tree and 4-5
> through
> the mips tree once patch 3 has been reviewed by the DT maintainers.

Without reading datasheet it all feels like a wrong place to put.

But maybe that SoC (SoC family?) has some update to DesignWare IP.
Btw, what the version of DW IP it's using? 2.00a? More older, more
recent?


> Alexandre Belloni (5):
> i2c: designware: factorize setting SDA hold time
> i2c: designware: allow IP specific sda_hold_time
> i2c: designware: add MSCC Ocelot support
> mips: dts: mscc: Add i2c on ocelot
> mips: dts: mscc: enable i2c on ocelot_pcb123
>
> .../bindings/i2c/i2c-designware.txt | 5 ++-
> arch/mips/boot/dts/mscc/ocelot.dtsi | 19 +++++++++++
> arch/mips/boot/dts/mscc/ocelot_pcb123.dts | 5 +++
> drivers/i2c/busses/i2c-designware-common.c | 33
> +++++++++++++++++++
> drivers/i2c/busses/i2c-designware-core.h | 3 ++
> drivers/i2c/busses/i2c-designware-master.c | 22 +------------
> drivers/i2c/busses/i2c-designware-platdrv.c | 20 +++++++++++
> drivers/i2c/busses/i2c-designware-slave.c | 22 +------------
> 8 files changed, 86 insertions(+), 43 deletions(-)
>

--
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy