Re: [PATCH v5 1/2] leds: core: Introduce generic pattern interface

[David Lechner]

On 07/16/2018 06:10 AM, Baolin Wang wrote:
> From: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>
>
> Some LED controllers have support for autonomously controlling
> brightness over time, according to some preprogrammed pattern or
> function.
>
> This adds a new optional operator that LED class drivers can implement
> if they support such functionality as well as a new device attribute to
> configure the pattern for a given LED.

Hmm... I was hoping that this would be a generic pattern trigger that
could be used by any LED (e.g. gpio LEDs), not just LEDs with hardware
support. I guess I cannot really test this after all.

I think it looks good for your use case though.