Re: [PATCH 14/18] kdb_support: change strncpy+truncation to strlcpy

[Daniel Thompson]

On Fri, Jul 13, 2018 at 05:18:51PM +0200, Dominique Martinet wrote:
> Daniel Thompson wrote on Fri, Jul 13, 2018:
> > On Fri, Jul 13, 2018 at 03:25:58AM +0200, Dominique Martinet wrote:
> > > Generated by scripts/coccinelle/misc/strncpy_truncation.cocci
> > > 
> > > Signed-off-by: Dominique Martinet <asmadeus@xxxxxxxxxxxxx>
> > 
> > It would have been good for you to mention in the changelog how
> > you reviewed your change to verify that the extra zero padding
> > from strncpy() isn't required.
> 
> I'm sorry, I went a bit too fast with the send-email button on this
> path series; I agree it is lacking.
> 
> > However... I have taken a look and can't see any problem so:
> > 
> > Reviewed-by: Daniel Thompson <daniel.thompson@xxxxxxxxxx>
> 
> Thank you for the review, I will update the commit message with more
> details and change strlcpy to strscpy in a v2

You can keep the reviewed by after the change to strscpy().