Re: [PATCH] mtd: cfi_cmdset_0002: remove redundant variable timeo

From: Boris Brezillon
Date: Sat Jul 07 2018 - 06:03:53 EST


On Tue, 3 Jul 2018 08:43:39 +0100
Colin King <colin.king@xxxxxxxxxxxxx> wrote:

> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> Variable is_local is being assigned but is never used hence it is
> redundant and can be removed.
>
> Cleans up clang warning:
> warning: variable 'timeo' set but not used [-Wunused-but-set-variable]
>
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>

Applied.

Thanks,

Boris

> ---
> drivers/mtd/chips/cfi_cmdset_0002.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/mtd/chips/cfi_cmdset_0002.c b/drivers/mtd/chips/cfi_cmdset_0002.c
> index 1b64ac8c5bc8..72428b6bfc47 100644
> --- a/drivers/mtd/chips/cfi_cmdset_0002.c
> +++ b/drivers/mtd/chips/cfi_cmdset_0002.c
> @@ -1216,7 +1216,6 @@ static inline int do_read_secsi_onechip(struct map_info *map,
> size_t grouplen)
> {
> DECLARE_WAITQUEUE(wait, current);
> - unsigned long timeo = jiffies + HZ;
>
> retry:
> mutex_lock(&chip->mutex);
> @@ -1229,7 +1228,6 @@ static inline int do_read_secsi_onechip(struct map_info *map,
>
> schedule();
> remove_wait_queue(&chip->wq, &wait);
> - timeo = jiffies + HZ;
>
> goto retry;
> }