Re: [PATCH net-next 3/6] net: mvneta: discriminate error cause for missed packet

From: David Miller
Date: Fri Jul 06 2018 - 22:09:12 EST


From: Gregory CLEMENT <gregory.clement@xxxxxxxxxxx>
Date: Fri, 6 Jul 2018 15:19:46 +0200

> @@ -609,6 +606,10 @@ struct mvneta_rx_queue {
>
> /* Index of the next RX DMA descriptor to process */
> int next_desc_to_proc;
> +
> + /* error counters */
> + u32 skb_alloc_err;
> + u32 refill_err;
> };

These counters aren't exported anywhere, making them not so useful.

Either remove this stuff or add them to the driver's ethtool state.

Thank you.