Re: [patch 6/7] x86/kvmclock: Move kvmclock vsyscall param and init to kvmclock

From: Thomas Gleixner
Date: Fri Jul 06 2018 - 15:23:56 EST


On Fri, 6 Jul 2018, Paolo Bonzini wrote:
> On 06/07/2018 18:13, Thomas Gleixner wrote:
> > @@ -241,6 +269,9 @@ void __init kvmclock_init(void)
> > return;
> > }
> >
> > + if (!hypervisor_is_type(X86_HYPER_KVM))
> > + kvmclock_vsyscall = 0;
> > +
>
> No need for this; by the time you get here, the condition will always be
> true. And if you don't have kvmclock, hv_clock will be NULL and
> initialization will be skipped anyway in kvm_setup_vsyscall_timeinfo.

Right, stupid me.