[PATCH] xarray: Fix lock/unlock imbalance in xa_alloc
From: Gustavo A. R. Silva
Date: Fri Jul 06 2018 - 09:10:53 EST
Release *xa_lock* before return.
Addresses-Coverity-ID: 1471631 ("Missing unlock")
Fixes: 29a6bfc32eb2 ("xarray: Track free entries in an XArray")
Signed-off-by: Gustavo A. R. Silva <gustavo@xxxxxxxxxxxxxx>
---
lib/xarray.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/lib/xarray.c b/lib/xarray.c
index be10039..a27fdb38 100644
--- a/lib/xarray.c
+++ b/lib/xarray.c
@@ -1474,8 +1474,10 @@ int xa_alloc(struct xarray *xa, u32 *id, void *entry, gfp_t gfp)
xas.xa_index = 0;
xas_lock(&xas);
xas_find_tagged(&xas, UINT_MAX, XA_FREE_TAG);
- if (xas.xa_node == XAS_BOUNDS && xas.xa_index == UINT_MAX + 1)
+ if (xas.xa_node == XAS_BOUNDS && xas.xa_index == UINT_MAX + 1) {
+ xas_unlock(&xas);
return -ENOSPC;
+ }
*id = xas.xa_index;
xas_store(&xas, entry);
xas_clear_tag(&xas, XA_FREE_TAG);
--
2.7.4