[PATCH] [net-next] devlink: fix incorrect return statement

From: Arnd Bergmann
Date: Fri Jul 06 2018 - 08:59:12 EST


A newly added dummy helper function tries to return a failure from a "void"
function:

In file included from include/net/dsa.h:24,
from arch/arm/plat-orion/common.c:21:
include/net/devlink.h: In function 'devlink_param_value_changed':
include/net/devlink.h:771:9: error: 'return' with a value, in function returning void [-Werror]
return -EOPNOTSUPP;

This fixes it by removing the bogus statement.

Fixes: ea601e170988 ("devlink: Add devlink notifications support for params")
Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
---
include/net/devlink.h | 1 -
1 file changed, 1 deletion(-)

diff --git a/include/net/devlink.h b/include/net/devlink.h
index 8ed571385626..f67c29cede15 100644
--- a/include/net/devlink.h
+++ b/include/net/devlink.h
@@ -768,7 +768,6 @@ devlink_param_driverinit_value_set(struct devlink *devlink, u32 param_id,
static inline void
devlink_param_value_changed(struct devlink *devlink, u32 param_id)
{
- return -EOPNOTSUPP;
}

#endif
--
2.9.0