Re: [PATCH v6 11/11] PCI: endpoint: Add MSI set maximum restriction.

From: Kishon Vijay Abraham I
Date: Fri Jul 06 2018 - 05:32:06 EST




On Thursday 21 June 2018 09:31 PM, Gustavo Pimentel wrote:
> Add pci_epc_set_msi() maximum 32 interrupts validation.
>
> Signed-off-by: Gustavo Pimentel <gustavo.pimentel@xxxxxxxxxxxx>
Acked-by: Kishon Vijay Abraham I <kishon@xxxxxx>
> ---
> Change v4->v5:
> - New patch file.
> Change v5->v6:
> - Nothing changed, just to follow the patch set version.
>
> drivers/pci/endpoint/pci-epc-core.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/pci/endpoint/pci-epc-core.c b/drivers/pci/endpoint/pci-epc-core.c
> index c72e656..094dcc3 100644
> --- a/drivers/pci/endpoint/pci-epc-core.c
> +++ b/drivers/pci/endpoint/pci-epc-core.c
> @@ -201,7 +201,8 @@ int pci_epc_set_msi(struct pci_epc *epc, u8 func_no, u8 interrupts)
> u8 encode_int;
> unsigned long flags;
>
> - if (IS_ERR_OR_NULL(epc) || func_no >= epc->max_functions)
> + if (IS_ERR_OR_NULL(epc) || func_no >= epc->max_functions ||
> + interrupts > 32)
> return -EINVAL;
>
> if (!epc->ops->set_msi)
>