Re: [PATCH v3 4/4] venus: firmware: register separate driver for firmware device

From: Rob Herring
Date: Thu Jul 05 2018 - 19:36:49 EST


On Thu, Jul 05, 2018 at 12:36:52AM +0530, Vikash Garodia wrote:
> A separate child device is added for video firmware.
> This is needed to
> [1] configure the firmware context bank with the desired SID.
> [2] ensure that the iova for firmware region is from 0x0.
>
> Signed-off-by: Vikash Garodia <vgarodia@xxxxxxxxxxxxxx>
> ---
> .../devicetree/bindings/media/qcom,venus.txt | 17 +++++++-

Reviewed-by: Rob Herring <robh@xxxxxxxxxx>

> drivers/media/platform/qcom/venus/core.c | 49 +++++++++++++++++++---
> drivers/media/platform/qcom/venus/firmware.c | 18 ++++++++
> drivers/media/platform/qcom/venus/firmware.h | 2 +
> 4 files changed, 80 insertions(+), 6 deletions(-)