Re: [PATCH] regmap: slimbus: add support to raw read/writes

From: Srinivas Kandagatla
Date: Thu Jul 05 2018 - 13:39:21 EST




On 05/07/18 18:30, Mark Brown wrote:
On Thu, Jul 05, 2018 at 06:20:50PM +0100, Srinivas Kandagatla wrote:

Access to codec registers is done in 2 steps.

1> Write page number in page register.
2> access register within the page.

This seems to exactly what struct regmap_range_cfg gives.

Adding ranges to regmap_config along with read/write bus callbacks works for
me.

OK, great - that's what I was expecting.

Thanks, I will respin the patch removing reference to raw in commit log and patch.

Are reg_read/reg_write callbacks in bus regmap redundant to read/write callbacks?

By the looks of it, it seems redundant, reg_read/reg_write will never be used if bus regmap has read/write callbacks. Just wanted reconfirm before replacing them with just read/write callbacks.

thanks,
srini