Re: [PATCH 1/4] scsi: aacraid: remove AAC_STAT_GOOD define

From: Bart Van Assche
Date: Thu Jul 05 2018 - 13:24:33 EST


On Thu, 2018-07-05 at 13:01 +0200, Johannes Thumshirn wrote:
> if (((aac_cache & 6) == 6) && dev->cache_protected) {
> - scsicmd->result = AAC_STAT_GOOD;
> + scsicmd->result = DID_OK << 16 | COMMAND_COMPLETE << 8 |
> + SAM_STAT_GOOD;

Does AAC_STAT_GOOD really have to be expanded in full multiple times?
Have you considered to replace AAC_STAT_GOOD by the numerical constant
0 instead?

Thanks,

Bart.