Re: [PATCHv3 0/5] pinctrl fixes for generic functions and groups

From: Andy Shevchenko
Date: Thu Jul 05 2018 - 09:55:50 EST


On Thu, Jul 5, 2018 at 12:10 PM, Tony Lindgren <tony@xxxxxxxxxxx> wrote:
> Here is a resend of fixes for a race issues for generic group and
> functions reported by H. Nikolaus Schaller <hns@xxxxxxxxxxxxx>.
>

Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>

I think for ACPI case we would use generic helpers, so this change is
quite useful to not screw up with new stuff.

> Regards,
>
> Tony
>
>
> Changes since v2:
>
> - Added Nikolaus to Cc as Reported-by did not do it
>
> Changes since v1:
>
> - Check if a function or group already exists as suggested by
> Andy Shevchenko
>
> - Make sure we always have a valid name for functions and groups
> as suggested by Christ van Willegen
>
> - Prettify rza1 variables as suggested by Jacopo Mondi
>
> Tony Lindgren (5):
> pinctrl: core: Return selector to the pinctrl driver
> pinctrl: pinmux: Return selector to the pinctrl driver
> pinctrl: single: Fix group and function selector use
> pinctrl: rza1: Fix selector use for groups and functions
> pinctrl: core: Remove broken remove_last group and pinmux functions
>
> drivers/pinctrl/core.c | 35 ++++++++++--
> drivers/pinctrl/core.h | 6 ---
> drivers/pinctrl/pinctrl-rza1.c | 24 +++++----
> drivers/pinctrl/pinctrl-single.c | 91 +++++++++++++++++++-------------
> drivers/pinctrl/pinmux.c | 16 ++++--
> drivers/pinctrl/pinmux.h | 7 ---
> 6 files changed, 112 insertions(+), 67 deletions(-)
>
> --
> 2.17.1



--
With Best Regards,
Andy Shevchenko