Re: [PATCH 3/3] drivers/speakup: Fix style and coding warnings

[Dan Carpenter]

On Tue, Jul 03, 2018 at 09:10:55AM +0100, Justin Skists wrote:
> > @@ -787,7 +787,7 @@ static ssize_t message_store_helper(const char *buf, size_t count,
> >  			continue;
> >  		}
> >  
> > -		index = simple_strtoul(cp, &temp, 10);
> > +		index = simple_ktrtoul(cp, &temp, 10);
> 
> Did you compile this?

Try to avoid rhetorical questions.  Just say "This doesn't compile.  Be
more careful."

regards,
dan carpenter