Re: [PATCH][V2] net: ethernet: sun: remove redundant variables adv and lpa and mii_reads

From: David Miller
Date: Thu Jul 05 2018 - 07:08:19 EST


From: Colin King <colin.king@xxxxxxxxxxxxx>
Date: Thu, 5 Jul 2018 12:05:25 +0100

> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> Variables adv and lpa are being assigned but are never used hence they
> are redundant and can be removed. Also remove the unncessary mii_reads
> too.
>
> Cleans up clang warnings:
> warning: variable 'lpa' set but not used [-Wunused-but-set-variable]
> warning: variable 'adv' set but not used [-Wunused-but-set-variable]
>
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> ---
>
> V2: remove mii_reads as suggessted by Dan Carpenter and David Miller

Applied, thanks Colin.