Re: [lkp-robot] [fs] 5c6de586e8: vm-scalability.throughput +12.4% improvement (from reorganizing struct inode?)

From: Amir Goldstein
Date: Thu Jul 05 2018 - 01:50:46 EST


On Thu, Jul 5, 2018 at 4:37 AM, Linus Torvalds
<torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
> On Wed, Jul 4, 2018 at 4:34 PM Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote:
>>
>> I don't hate that patch, but there are immediate followup questions - e.g.
>> how sensitive is relative position of i_lock/i_hash/i_sb? Those are *not*
>> close to each other. E.g. what happens if one moves i_hash right after
>> i_ino?
>
> I think that's a separate issue from just packing things better.
>
> The original patch is at
>
> https://marc.info/?l=linux-fsdevel&m=152880180732361&w=2
>
> although I certainly agree with the "just re-send as a proper patch,
> now with a note on potential performance improvements".
>

Will do. But first, let me CC this discussion to some public lists,
so I have somewhere to refer to in commit message...

Thanks,
Amir.