Re: [PATCH 1/2] Revert "mfd: cros_ec: Remove unused __remove function"

[Lee Jones]

On Wed, 04 Jul 2018, Dmitry Torokhov wrote:
> On Wed, Jul 04, 2018 at 07:48:11AM +0100, Lee Jones wrote:
> > On Wed, 20 Jun 2018, Dmitry Torokhov wrote:
> > 
> > > This reverts commit 556c242045f0c1613aac2e64dc5b2ff0e4bc89e1.
> > > 
> > > The patch that this change is purported to fix is broken and should be
> > > reverted; thus we reverting this one as well.
> > 
> > You need to provide more information.
> > 
> > How does the original patch break the build/code execution?
> > What is this patch doing to rectify the issue?
> > Any other information you think is relevant.
> 
> We are reverting this patch because it is not needed: it tries to fix
> another patch that is completely broken and needs to be reverted. The
> justification for reverting the original broken patch is in the revert
> of that patch, but just for reference:
> 
> We should not use devm_kzalloc() to allocate refcounted objects.

The other patch looked good.  Please ensure the story is told in each
of the patches individually though.  That way they can be are viewed
by an outsider the history can be read and understood independently.

Thanks in advance.

-- 
Lee Jones [æçæ]
Linaro Services Technical Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog