Re: [PATCH 3/3] fs/dax: Assigning NULL to gfn of dax_direct_access if useless

From: Huaisheng Ye
Date: Wed Jul 04 2018 - 09:08:16 EST


---- On Wed, 04 Jul 2018 19:30:12 +0800 Jan Kara <jack@xxxxxxx> wrote ----
> On Wed 04-07-18 14:40:58, Huaisheng Ye wrote:
> > From: Huaisheng Ye <yehs1@xxxxxxxxxx>
> >
> > Some functions within fs/dax don't need to get gfn from direct_access.
> > Assigning NULL to gfn of dax_direct_access is more intuitive and simple
> > than offering a useless local variable.
> >
> > Signed-off-by: Huaisheng Ye <yehs1@xxxxxxxxxx>
>
> I like this. You can add:
>
> Reviewed-by: Jan Kara <jack@xxxxxxx>
>
> for the series.
>
> Honza
>
I am so happy you like them, thank you very much.

---
Cheers,
Huaisheng