Re: [RFC PATCH] ACPI: bus: match of_device_id using acpi device

From: Andy Shevchenko
Date: Wed Jul 04 2018 - 05:32:28 EST


On Wed, Jul 4, 2018 at 6:37 AM, Srinath Mannam
<srinath.mannam@xxxxxxxxxxxx> wrote:
> Hi Sudeep, Andy,
>
> Yes, This patch is to get of_device_id and then fetch data pointer.
>
> To add ACPI support in multiple drivers which are device-tree based
> and has list of of_device_ids, by using this function
> very minimal changes and can avoid acpi_device_id list in the driver.
> I will send driver changes where this function used to add ACPI
> support in following patches.
>
> Below are the changes added to add ACPI support in sdhci iproc driver
> using this function.

So, did you get an ACPI ID for it?
That's how proper ACPI support should be done.

P.S. What you are trying to do is being discussed with Nikolaus in [1].
I have to NAK your approach in any case. Sorry.

[1]:
https://www.mail-archive.com/linux-kernel@xxxxxxxxxxxxxxx/msg1724366.html
(Unfortunately I don't see the original patch there by unknown reason)

--
With Best Regards,
Andy Shevchenko