Re: [PATCH] gpiolib: Defer on non-DT find_chip_by_name() failure

From: Andy Shevchenko
Date: Tue Jul 03 2018 - 16:07:41 EST


On Tue, Jul 3, 2018 at 8:26 PM, Janusz Krzysztofik <jmkrzyszt@xxxxxxxxx> wrote:
> Avoid replication of error code conversion in non-DT GPIO consumers'
> code by returning -EPROBE_DEFER from gpiod_find() in case a chip
> identified by its label in a registered lookup table is not ready.
>
> See https://lkml.org/lkml/2018/5/30/176 for example case.

> + /*
> + * As the lookup table indicates a chip with
> + * p->chip_label should exist, assume it may
> + * still appear latar and let the interested

latar -> later

> + * consumer be probed again or let the Deferred
> + * Probe infrastructure handle the error.
> + */
> + dev_warn(dev, "cannot find GPIO chip %s, deferring\n",
> + p->chip_label);
> + return ERR_PTR(-EPROBE_DEFER);
> }

--
With Best Regards,
Andy Shevchenko