Re: [PATCH] i2c: designware-pcidrv: Mark expected switch fall-through

From: Andy Shevchenko
Date: Tue Jul 03 2018 - 15:16:51 EST


On Tue, 2018-07-03 at 14:10 -0500, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
>
> where we are expecting to fall through.

Acked-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

>
> Signed-off-by: Gustavo A. R. Silva <gustavo@xxxxxxxxxxxxxx>
> ---
> drivers/i2c/busses/i2c-designware-pcidrv.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/i2c/busses/i2c-designware-pcidrv.c
> b/drivers/i2c/busses/i2c-designware-pcidrv.c
> index 86e1bd0..b4997be 100644
> --- a/drivers/i2c/busses/i2c-designware-pcidrv.c
> +++ b/drivers/i2c/busses/i2c-designware-pcidrv.c
> @@ -105,6 +105,7 @@ static int mfld_setup(struct pci_dev *pdev, struct
> dw_pci_controller *c)
> case 0x0817:
> c->bus_cfg &= ~DW_IC_CON_SPEED_MASK;
> c->bus_cfg |= DW_IC_CON_SPEED_STD;
> + /* fall through */
> case 0x0818:
> case 0x0819:
> c->bus_num = pdev->device - 0x817 + 3;

--
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy