Re: [PATCH v4 00/27] Venus updates

From: Alexandre Courbot
Date: Tue Jul 03 2018 - 04:49:36 EST


On Tue, Jul 3, 2018 at 12:25 AM Stanimir Varbanov
<stanimir.varbanov@xxxxxxxxxx> wrote:
>
> Hi Alex,
>
> Thanks for review comments!
>
> On 07/02/2018 11:45 AM, Alexandre Courbot wrote:
> > Hi Stanimir,
> >
> > Thanks for this very well organized series and sorry for not giving
> > feedback earlier.
> >
> > I have tested this version against the 4.14 Chrome OS kernel tree (+ a
> > few extra changes to comply with the codec API) and it was working
> > flawlessly.
> >
> > Therefore,
> >
> > Tested-by: Alexandre Courbot <acourbot@xxxxxxxxxxxx>
>
> Thanks for testing!
>
> >
> > For the whole series.
> >
> > I have a few comments/questions on some patches, would be great if you
> > could take a look. Also wondering what is your plan regarding codec
> > API compliance? Do you plan to integrate it into the current series,
> > or work on it after merging this initial work? Both ways would be ok
> > as far as I am concerned.
>
> Unfortunately I'm not ready with codec API compliance (at least for
> Venus v1 & v3). I'm working on that intensively these days and I'd say
> with a good progress but I still have few issues/details which needs
> more attention and time.
>
> So I guess the plan minimum is to merge this series first.

I'm fine with that. That will also allow us to tune the Codec API spec
using this driver as reference.