Re: [PATCH 0/3] IIO: st_sensors_i2c: improve device enumeration

[Nikolaus Voss]

On Mon, 2 Jul 2018, Andy Shevchenko wrote:
> On Mon, Jul 2, 2018 at 9:41 AM, Nikolaus Voss
> <nikolaus.voss@xxxxxxxxxxxxxxxxxxxxx> wrote:
> > On Fri, 29 Jun 2018, Andy Shevchenko wrote:
> >
> > > I'm not sure I understand how ->probe_new() is supposed to work
> > > against i2c_id_table, but I don't care for legacy platform data
> > > anyway.
> > >
> > > What I would like to point to is device_get_match_data() API which
> > > should simplify / unify the case how you get driver data.
> >
> >
> > This driver doesn't need any driver data/ platform_data beyond the
> > i2c_id_table name (which has already been matched when probe()/ probe_new()
> > is called), so strictly neither of_match_table nor apci_match_table would be
> > necessary, because i2c DT/ ACPI enumeration also matches against i2c_table
> > names.
>
> Looking at the code I see still calls to acpi_match_data() and of_match_data().
> Instead nowadays better to use device_get_match_data().

You are completely right, sorry. I rewrote and reposted the patch.

> i2c_id_table should be removed from the module device table at least
> (though you may continue to use it internally in the driver).

As I understand it, it is still necessary to make 
i2c_register_board_info() work.

Niko