Re: [PATCH v3] add param that allows bootline control of hardened usercopy

From: Kees Cook
Date: Mon Jul 02 2018 - 14:43:51 EST


On Sat, Jun 30, 2018 at 1:43 PM, Christoph von Recklinghausen
<crecklin@xxxxxxxxxx> wrote:
> The last issue I'm chasing is build failures on ARCH=m68k. The error is
> atomic_read and friends needed by the jump label code not being found.
> The config has CONFIG_BROKEN_ON_SMP=y, so the jump label calls I added
> will only be made #ifndef CONFIG_BROKEN_ON_SMP. Do you think that's
> worth a mention in the blurb that's added to
> Documentation/admin-guide/kernel-parameters.txt?

Uhm, that's weird -- I think the configs on m68k need fixing then? I
don't want to have to sprinkle that ifdef in generic code.

How are other users of static keys and jump labels dealing with m68k weirdness?

-Kees

--
Kees Cook
Pixel Security