Re: [PATCH v1] ARM: dts: imx6sl-evk: keep sw4 always on

From: Fabio Estevam
Date: Sun Jul 01 2018 - 19:33:06 EST


On Sun, Jul 1, 2018 at 6:34 AM, Shawn Guo <shawnguo@xxxxxxxxxx> wrote:
> On Mon, Jun 25, 2018 at 08:34:11PM +0800, Robin Gong wrote:
>> SW4 is one power rail for LPDDR2 on i.mx6sl-evk, so it should
>> be kept always on. But it's disabled after switch disabled
>> interface implemented in pfuze driver
>> 'commit 5fe156f1cab4
>> ("regulator: pfuze100: add enable/disable for switch")'.Thus,
>> it breaks kernel bootup. Add 'regulator-always-on' for SW4.
>>
>> Signed-off-by: Robin Gong <yibin.gong@xxxxxxx>
>
> Does that mean boards with existing DTB installed will stop working with
> new kernel? That's bad, and the kernel commit should probably be
> reverted.

Yes, this is a good point.

Anson,

Should 5fe156f1cab4 ("regulator: pfuze100: add enable/disable for
switch") be reverted to avoid such breakage?