Re: [PATCH v8 2/5] ipc: IPCMNI limit check for semmni

From: Waiman Long
Date: Fri Jun 29 2018 - 03:26:32 EST


On 06/29/2018 06:39 AM, Luis R. Rodriguez wrote:
> On Mon, Jun 18, 2018 at 06:28:15PM +0800, Waiman Long wrote:
>> For SysV semaphores, the semmni value is the last part of the 4-element
>> sem number array. To make semmni behave in a similar way to msgmni and
>> shmmni, we can't directly use the _minmax handler. Instead, a special
>> sem specific handler is added to check the last argument to make sure
>> that it is limited to the [0, IPCMNI] range. An error will be returned
>> if this is not the case.
> Sorry my time has run out, and will be on vacation until July 10th. If
> this can wait until then then great, otherwise hopefully Kees can take
> a look. It would be wonderful to get Eric's review on this as well.
>
> Luis

Thanks for the review. I will try to get other reviewer to chime in.

Kees and Eric, do you have comments on this patchset?

Cheers,
Longman