Re: [PATCH v2] drivers: base: initcall_debug logs for driver probe times

From: Rob Herring
Date: Mon Jun 25 2018 - 11:21:03 EST


On Wed, Jun 20, 2018 at 05:35:56PM -0700, Todd Poynor wrote:
> From: Todd Poynor <toddpoynor@xxxxxxxxxx>
>
> Add initcall_debug logs for each driver device probe call, for example:
>
> probe of a3800000.ramoops returned 1 after 3007 usecs
>
> This replaces the previous code added to report times for deferred
> probes. It also reports OF platform bus device creates that were
> formerly lumped together in a single entry for function
> of_platform_default_populate_init, as well as helping to annotate other
> initcalls that involve device probing.
>
> Remove restriction on printing probe times only during initcalls, since
> initcall_debug now continues to show driver timing info past the boot
> phase.
>
> Signed-off-by: Todd Poynor <toddpoynor@xxxxxxxxxx>
> ---
> drivers/base/dd.c | 50 +++++++++++++++++++++--------------------------
> 1 file changed, 22 insertions(+), 28 deletions(-)
>
> Changes from v1:
> * unsigned long long -> s64
> * use ktime_to_us() instead of ktime_to_ns with shift
> * print probe return value
> * drop code that stopped output on end of initcall processing

Reviewed-by: Rob Herring <robh@xxxxxxxxxx>