Re: [PATCH] staging: gdm724x: add error handling for nlmsg_put

From: Dan Carpenter
Date: Thu Jun 14 2018 - 10:14:54 EST


On Thu, Jun 14, 2018 at 11:27:26AM +0800, Zhouyang Jia wrote:
> Hi,
>
> I reported this bug since more than 95% callsites of nlmsg_put are
> well handled in kernel, and many of them also allocated skb before.
>

That's probably true, but the NULL check is not required *here*.

Just mark it as a false positive in your tool and move on... It's not
like we are close to running out of real bugs to deal with.

regards,
dan carpenter