Re: [PATCH 5/5] soc: qcom: Remove depends on ARCH_QCOM

[Vivek Gautam]

Hi NIklas,


On 6/14/2018 2:01 PM, Niklas Cassel wrote:
> On Thu, Jun 14, 2018 at 12:08:10PM +0530, Vivek Gautam wrote:
> > On Thu, Jun 14, 2018 at 12:05 PM, Vivek Gautam
> > <vivek.gautam@xxxxxxxxxxxxxx> wrote:
> > > On Wed, Jun 13, 2018 at 6:24 PM, Niklas Cassel <niklas.cassel@xxxxxxxxxx> wrote:
> > > > Since commit cab673583d96 ("soc: Unconditionally include qcom Makefile"),
> > > > we unconditionally include the soc/qcom/Makefile.
> > > >
> > > > This opens up the possibility to compile test the code even when
> > > > building for other architectures.
> > > Why do we want to do this when all of it is qcom specific?
> > > Besides, wouldn't this increase the binary size for other platforms.
> To be able to compile test drivers that select some of these Kconfigs,
> even when building for other architectures.

Are these other drivers which select these Kconfigs not QCOM dependent?
We should make them so if that's not the case, and also add COMPILE_TEST
for them too.

> The binary size shouldn't increase if they don't enable these Kconfigs.
>
> > Sorry, my bad. Send the message without completing.
> >
> > Besides above points, the COMPILE_TEST flag should allow you
> > to compile test all of these drivers. If COMPILE_TEST is missing
> > in some of the configs, we should try adding that.
> > Or, is there anything that I am missing here for the intention of this patch?
> That is another alternative.
> So either make sure that all these Kconfigs
> have "depends on ARCH_QCOM || COMPILE_TEST",
> or
> remove ARCH_QCOM from these Kconfigs.
>
> A third, and perhaps best alternative is to do like
> drivers/soc/mediatek/Kconfig
>
> menu "MediaTek SoC drivers"
>      depends on ARCH_MEDIATEK || COMPILE_TEST
>
> Make sure that our root menu entry depends on ARCH_QCOM || COMPILE_TEST,
> that way we could remove ARCH_QCOM for all Kconfigs.
>
> Thoughts?

To me the first and third approach look same. So I will leave it to Andy 
to decide
which is cleaner.
For 2nd option, I would still say that there shouldn't be a need for 
these drivers
to be compiled outside of the ARCH_QCOM, besides for compile test purpose.

Thanks & Regards
Vivek

> Regards,
> Niklas
> --
> To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html