Re: [PATCH][next] pinctrl: pinctrl-single: add allocation failure checking of saved_vals

[Linus Walleij]

On Wed, Jun 6, 2018 at 3:43 PM, Colin King <colin.king@xxxxxxxxxxxxx> wrote:

> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> Currently saved_vals is being allocated and there is no check for
> failed allocation (which is more likely than normal when using
> GFP_ATOMIC).  Fix this by checking for a failed allocation and
> propagating this error return down the the caller chain.
>
> Detected by CoverityScan, CID#1469841 ("Dereference null return value")
>
> Fixes: 88a1dbdec682 ("pinctrl: pinctrl-single: Add functions to save and restore pinctrl context")
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>

Patch applied with Johan's and Tony's ACKs.

Yours,
Linus Walleij