Re: [PATCH] arm64: dts: hikey960: Define wl1837 power capabilities

From: Kalle Valo
Date: Thu Jun 14 2018 - 02:21:09 EST


John Stultz <john.stultz@xxxxxxxxxx> writes:

> On Wed, Jun 13, 2018 at 11:03 AM, Ryan Grachek <ryan@xxxxxxxxx> wrote:
>> These properties are required for compatibility with runtime PM.
>> Without these properties, MMC host controller will not be aware
>> of power capabilities. When the wlcore driver attempts to power
>> on the device, it will erroneously fail with -EACCES. This fixes
>> a regression found here: https://lkml.org/lkml/2018/6/12/930
>>
>> Signed-off-by: Ryan Grachek <ryan@xxxxxxxxx>
>
> Fixes: 60f36637bbbd ("wlcore: sdio: allow pm to handle sdio power")
> Tested-by: John Stultz <john.stultz@xxxxxxxxxx>
> Acked-by: John Stultz <john.stultz@xxxxxxxxxx>
>
> Wei Xu: This also fixes a functional regression with wifi on the
> HiKey960 board that was introduced in 4.18-rc with commit 60f36637bbbd
> ("wlcore: sdio: allow pm to handle sdio power").
>
> Could you please be sure to queue this for the 4.18-rc too?

CCing wireless folks as well.

--
Kalle Valo