Re: [RFC PATCH 16/23] watchdog/hardlockup: Add an HPET-based hardlockup detector

From: Ricardo Neri
Date: Wed Jun 13 2018 - 21:04:37 EST


On Tue, Jun 12, 2018 at 10:23:47PM -0700, Randy Dunlap wrote:
> Hi,

Hi Randy,

>
> On 06/12/2018 05:57 PM, Ricardo Neri wrote:
> > diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> > index c40c7b7..6e79833 100644
> > --- a/lib/Kconfig.debug
> > +++ b/lib/Kconfig.debug
> > @@ -828,6 +828,16 @@ config HARDLOCKUP_DETECTOR_PERF
> > bool
> > select SOFTLOCKUP_DETECTOR
> >
> > +config HARDLOCKUP_DETECTOR_HPET
> > + bool "Use HPET Timer for Hard Lockup Detection"
> > + select SOFTLOCKUP_DETECTOR
> > + select HARDLOCKUP_DETECTOR
> > + depends on HPET_TIMER && HPET
> > + help
> > + Say y to enable a hardlockup detector that is driven by an High-Precision
> > + Event Timer. In addition to selecting this option, the command-line
> > + parameter nmi_watchdog option. See Documentation/admin-guide/kernel-parameters.rst
>
> The "In addition ..." thing is a broken (incomplete) sentence.

Oops. I apologize. I missed this I will fix it in my next version.

Thanks and BR,
Ricardo