Re: [PATCH v6 3/4] dt-bindings: power: supply: qcom_bms: Add bindings

From: Matthias Kaehlcke
Date: Wed Jun 13 2018 - 18:53:36 EST


(sorry if you receive two variants of this mail, I sent one earlier
today but for some reason it didn't make it to the lists)

On Wed, Jun 13, 2018 at 05:06:24PM +0100, Craig Tatlor wrote:
> Add bindings for the Qualcomm Battery Monitoring system.
>
> Signed-off-by: Craig Tatlor <ctatlor97@xxxxxxxxx>
> ---
>
> * Changes from v5:
> Mentions which values are 8 bit.
>
> * Changes from v4:
> Uses proper units and expands some definitions,
> along with changing vadc@ to adc@.
> .../bindings/power/supply/qcom_bms.txt | 92 +++++++++++++++++++
> 1 file changed, 92 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/power/supply/qcom_bms.txt
>
> diff --git a/Documentation/devicetree/bindings/power/supply/qcom_bms.txt b/Documentation/devicetree/bindings/power/supply/qcom_bms.txt
> new file mode 100644
> index 000000000000..9a29a2eb9f04
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/power/supply/qcom_bms.txt
> @@ -0,0 +1,92 @@
> +Qualcomm Battery Monitoring System
> +
> +The Qualcomm Battery Monitoring System is found inside of Qualcomm PM8941
> +PMICs. It provides open circuit voltage (OCV) and coulomb counter registers
> +that allow the OS to infer a capacity level.
> +
> +Required properties:
> +- compatible: Should contain "qcom,pm8941-bms".
> +- reg: Specifies the SPMI address and length of the
> + controller's registers.
> +- interrupts: OCV threshold interrupt.
> +- io-channels: Should contain IIO channel specifier for the
> + ADC channel that reports battery temperature.
> +- io-channel-names: Should contain "temp".
> +- qcom,fcc-temp-legend-celcius: An 8 bit array containing the temperature,
> + in degC, for each column of the full charge
> + capacity lookup table.

s/celcius/celsius/

same for qcom,ocv-temp-legend-celcius

> +- qcom,fcc-lut-microamp-hours: An array of full charge capacity values in uah,
> + one entry for each temperature defined in in

nit: s/uah/uAh/

Thanks

Matthias