Re: [PATCH] PM / core: Fix supplier device runtime PM usage counter imbalance

From: Rafael J. Wysocki
Date: Wed Jun 13 2018 - 03:59:02 EST


On Tue, Jun 12, 2018 at 9:43 PM, Ulf Hansson <ulf.hansson@xxxxxxxxxx> wrote:
> On 12 June 2018 at 14:44, Marek Szyprowski <m.szyprowski@xxxxxxxxxxx> wrote:

[cut]

>>
>> Is there any way to keep old behavior?
>
> I think the old behavior is sub-optimal. I am sure there are users
> that really don't want the driver core to runtime resume the supplier
> unconditionally.

I agree.

That said, the existing behavior has been there for quite a while and
the callers of device_link_add() that have grown a dependency on it
should be given a chance to change before it goes away.

> I would rather go and fix the few users of device_link_add(), to use
> DL_FLAG_RPM_ACTIVE, in cases when they need it.

Which BTW was the original idea. :-)

> Of course I am fine if we do these changes in a step by step basis as well.

OK, because that's what I'd prefer to do.