Re: [PATCH] staging: pi433: add mutex fixing race condition when accessing tx_cfg

From: Hugo Lefeuvre
Date: Tue Jun 12 2018 - 20:50:00 EST


> We read the data from the user here and then we write it to the fifo
> in pi433_write(). We should be using the device->tx_fifo_lock so that
> we don't copy over the data at the same time we're writing it to the
> fifo.

Oh right, that makes the bug even worse.

In this case we don't even need to introduce a new lock, using
device->tx_fifo_lock should be fine. I'll update the patch.

--
Hugo Lefeuvre (hle) | www.owl.eu.com
4096/ 9C4F C8BF A4B0 8FC5 48EB 56B8 1962 765B B9A8 BACA

Attachment: signature.asc
Description: PGP signature