Re: [PATCH 01/19 v3] regulator: fixed: Convert to use GPIO descriptor only

From: Mark Brown
Date: Tue Jun 12 2018 - 07:01:00 EST


On Tue, Jun 12, 2018 at 10:15:40AM +0200, Linus Walleij wrote:
> On Mon, Jun 11, 2018 at 5:00 PM, Mark Brown <broonie@xxxxxxxxxx> wrote:
> > On Mon, Jun 11, 2018 at 03:11:14PM +0200, Linus Walleij wrote:

> >> Sadly this only handled the undocumented fixed
> >> regulator binding "reg-fixed-voltage". So I need to fix it
> >> for "regulator-fixed" as well, and then it "should work".

> > The normal fixed voltage regulator parses enable-active-high?

> Yeah currently. However I moved the handling to the gpiolib
> parsing code to centralize polarity inversion handling, in an
> attempt so keep things under control. So in the patch series
> this flag handling moves over to the gpiolib.

Ah, I see - you're talking about the series rather than the current
state of the code, I thought you were talking about the current state of
the code which was why I was confused.

> I was thinking to do the same with other subsystems, such as
> MMC to get legacy GPIO flags under control and contained.

Yes, it'd be good to try to make this clearer for users - having so many
ways of specifying the same thing makes everything hard to understand.

Attachment: signature.asc
Description: PGP signature