Re: [PATCH] x86/iommu: Fix a typo in a macro parameter

From: Masatake YAMATO
Date: Wed Jun 06 2018 - 10:03:12 EST


On Wed, 6 Jun 2018 14:41:57 +0200 (CEST), Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote:
> On Wed, 6 Jun 2018, Thomas Gleixner wrote:
>> On Wed, 6 Jun 2018, Masatake YAMATO wrote:
>> > On Wed, 6 Jun 2018 12:37:34 +0200 (CEST), Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote:
>> > > On Wed, 6 Jun 2018, Masatake YAMATO wrote:
>> > >
>> > > Can you please explain why 0 is the wrong value.
>> >
>> > I don't know such constants, 0 and 1.
>> >
>> > What I change is just the name of macro parameter as
>> >
>> > s/detect/_detect/
>>
>> OOps. Misread the patch. Sorry.
>
> But the fix is pretty pointless. IOMMU_INIT_POST_FINISH() is completely
> unused and should just be removed.

Oh, I see. Thank you for taking your time.

Masatake YAMATO

> Thanks,
>
> tglx