RE: [PATCH 4.4 011/268] Revert "ipc/shm: Fix shmat mmap nil-page protection"

[Daniel Sangorrin]

> -----Original Message-----
> From: Naresh Kamboju [mailto:naresh.kamboju@xxxxxxxxxx]
> Sent: Friday, June 1, 2018 12:55 AM
> To: Daniel Sangorrin <daniel.sangorrin@xxxxxxxxxxxxx>
> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>; open list
> <linux-kernel@xxxxxxxxxxxxxxx>; linux- stable <stable@xxxxxxxxxxxxxxx>;
> Davidlohr Bueso <dbueso@xxxxxxx>; Joe Lawrence <joe.lawrence@xxxxxxxxxx>;
> Andrea Arcangeli <aarcange@xxxxxxxxxx>; Manfred Spraul
> <manfred@xxxxxxxxxxxxxxxx>; Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>;
> Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
> Subject: Re: [PATCH 4.4 011/268] Revert "ipc/shm: Fix shmat mmap nil-page
> protection"
> 
> On 31 May 2018 at 13:06, Daniel Sangorrin
> <daniel.sangorrin@xxxxxxxxxxxxx> wrote:
> >> -----Original Message-----
> >> From: 'Greg Kroah-Hartman' [mailto:gregkh@xxxxxxxxxxxxxxxxxxx]
> > ..
> >> Thanks for letting us know, but this was reported already.  See the
> >> emails on lkml with the subject:
> >>       Subject: Re: [PATCH 4.16 000/272] 4.16.13-stable review
> >> from Davidlohr Bueso
> >>       Message-ID: <20180528213039.yy2madue67njkmw5@linux-n805>
> >>
> >> where he discusses that the LTP test is incorrect and that the kernel
> >> change is correct and that LTP is going to be fixed because of this.
> 
> My two cents,
> If you are referring to cve-2017-5669.c
> LTP test case is been fixed few hours ago by Rafael Tinoco,
> 
> - shm_addr = shmat(shm_id, ((void *)1), SHM_RND);
> + shm_addr = shmat(shm_id, ((void *)1), SHM_RND | SHM_REMAP);
> 
> LTP patch pull request and it is been merged.
> https://github.com/linux-test-project/ltp/pull/324

Thanks a lot Naresh.
I confirmed that the latest LTP cve-2017-5669 now PASSes.

Thanks,
Daniel