Re: [PATCH 3/3] drm/amdgpu: Add documentation for PRIME related code

[Michel DÃnzer]

On 2018-06-01 03:44 PM, Alex Deucher wrote:
> On Fri, Jun 1, 2018 at 9:40 AM, Michel DÃnzer <michel@xxxxxxxxxxx> wrote:
>> On 2018-06-01 02:58 PM, Alex Deucher wrote:
>>> On Thu, May 31, 2018 at 12:17 PM, Michel DÃnzer <michel@xxxxxxxxxxx> wrote:
>>>> From: Michel DÃnzer <michel.daenzer@xxxxxxx>
>>>>
>>>> Signed-off-by: Michel DÃnzer <michel.daenzer@xxxxxxx>
>>>
>>> Series is:
>>> Reviewed-by: Alex Deucher <alexander.deucher@xxxxxxx>
>>
>> Thanks. Is it okay to merge all of these via the amdgpu tree, or should
>> I wait for an ack from Jon and/or core DRM maintainers for that?
> 
> GPU documentation usually goes through the drm trees.  You might want
> to push patch 1 (drm_mm.rst fix) via drm_misc, but the rest are can go
> in via the amdgpu tree since they are amdgpu specific.

I'd prefer merging all three patches together, since without patch 1,
patch 3 generates the warning below while generating documentation, and
the reference to the PRIME Buffer Sharing section doesn't work.

.../linux/Documentation/gpu/amdgpu.rst:2: WARNING: undefined label:
prime_buffer_sharing (if the link has no caption the label must precede
a section header)


-- 
Earthling Michel DÃnzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer