Re: v4.17-rc1: regressions on N900, N950

From: Pavel Machek
Date: Tue May 29 2018 - 16:45:28 EST


Hi!

> > > still results in working touchscreen, removing any of the three fields
> > > breaks it again.
> >
> > I bisected one regression down, see "omapdrm regression in v4.17-rc series"
> > not sure if it covers all the issues being discussed here though.
>
> Reverting 24aac6011f70 fixes screen on n900 in v4.17-rc for me. (But
> strange dependency on tsc2005@0 is still there).

Laurent, your patch looks pretty obvious, but unfortunately breaks
display on Nokia N900.

The patch is pretty big as is, perhaps you have version split to sdi
=> *sdi and then static => dynamic allocation?

Thanks,
Pavel

commit 24aac6011f704d69b5f34514923413f85669f282
Author: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
Date: Tue Feb 13 14:00:47 2018 +0200

drm: omapdrm: sdi: Allocate the sdi private data structure
dynamically

The sdi private data structure is currently stored as a global
variable. While no platform with multiple SDI encoders
currently exists
nor is planned, this doesn't comply with the kernel device
model and
should thus be fixed.



--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Attachment: signature.asc
Description: Digital signature