Re: [PATCH v11 1/2] cpufreq: Add Kryo CPU scaling driver

From: Sudeep Holla
Date: Thu May 24 2018 - 04:45:20 EST


On Thu, May 24, 2018 at 10:04:43AM +0530, Viresh Kumar wrote:
> On 23-05-18, 14:25, Sudeep Holla wrote:
> > On 23/05/18 13:38, Ilia Lin wrote:
> > > +config ARM_QCOM_CPUFREQ_KRYO
> > > + bool "Qualcomm Kryo based CPUFreq"
> > > + depends on QCOM_QFPROM
> > > + depends on QCOM_SMEM
> > > + select PM_OPP
> > > + help
> > > + This adds the CPUFreq driver for Qualcomm Kryo SoC based boards.
> > > +
> > > + If in doubt, say N.
> > > +
> >
> > Sorry but just noticed now, any reason why this can't be module. I can't
> > imagine any.
>
> Actually I asked him to do that as cpufreq-dt itself can be compiled
> in as module and this driver wasn't doing much and isn't big enough
> (size wise) as well.
>

Initially I guessed that to be the reason, but not prevents this to be a
module. But you are right, the gain is not much as this driver is quite
small on it's own.

--
Regards,
Sudeep