Re: [PATCH] scsi: clean up generated file scsi_devinfo_tbl.c

From: Hannes Reinecke
Date: Mon May 14 2018 - 01:52:35 EST


On Sun, 13 May 2018 17:10:52 -0700
Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote:

> From: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
>
> "make clean" should remove the generated file "scsi_devinfo_tbl.c",
> so list it in the clean-files variable so that the file gets
> cleaned up.
>
> Fixes: 345e29608b4b ("scsi: scsi: Export blacklist flags to sysfs")
>
> Cc: Hannes Reinecke <hare@xxxxxxx>
> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> ---
> drivers/scsi/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-4.17-rc4.orig/drivers/scsi/Makefile
> +++ linux-4.17-rc4/drivers/scsi/Makefile
> @@ -182,7 +182,7 @@ zalon7xx-objs := zalon.o ncr53c8xx.o
> NCR_Q720_mod-objs := NCR_Q720.o ncr53c8xx.o
>
> # Files generated that shall be removed upon make clean
> -clean-files := 53c700_d.h 53c700_u.h
> +clean-files := 53c700_d.h 53c700_u.h scsi_devinfo_tbl.c
>
> $(obj)/53c700.o $(MODVERDIR)/$(obj)/53c700.ver: $(obj)/53c700_d.h
>
>
>

Reviewed-by: Hannes Reinecke <hare@xxxxxxxx>

Cheers,

Hannes