Re: [PATCH] edac: fix skx_edac build error when ACPI_NFIT=m

From: Borislav Petkov
Date: Sun May 13 2018 - 07:13:11 EST


On Sat, May 12, 2018 at 06:02:12PM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
>
> Prevent build error when CONFIG_ACPI_NFIT=m and CONFIG_EDAC_SKX=y
> by limiting EDAC_SKX based on how ACPI_NFIT is set.
>
> Fixes this build error:
> drivers/edac/skx_edac.o: In function `get_nvdimm_info':
> ../drivers/edac/skx_edac.c:399: undefined reference to `nfit_get_smbios_id'
>
> Fixes: 58ca9ac1463d ("EDAC, skx_edac: Detect non-volatile DIMMs")
>
> Reported-by: kbuild test robot <lkp@xxxxxxxxx>
> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> Cc: Tony Luck <tony.luck@xxxxxxxxx>
> Cc: Borislav Petkov <bp@xxxxxxxxx>
> Cc: Mauro Carvalho Chehab <mchehab@xxxxxxxxxx>
> Cc: stable@xxxxxxxxxxxxxxx
> ---
> drivers/edac/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> --- lnx-417-rc4.orig/drivers/edac/Kconfig
> +++ lnx-417-rc4/drivers/edac/Kconfig
> @@ -232,6 +232,7 @@ config EDAC_SBRIDGE
> config EDAC_SKX
> tristate "Intel Skylake server Integrated MC"
> depends on PCI && X86_64 && X86_MCE_INTEL && PCI_MMCONFIG
> + depends on ACPI_NFIT || !ACPI_NFIT

I guess...

Although this reads really non-sensical. But it looks like enforcing the
state of the dependent symbol is being done in other places so please
add a comment similar to like it is done in those other places so that
it is clear:

drivers/usb/phy/Kconfig:25: depends on USB_GADGET || !USB_GADGET # if USB_GADGET=m, this can't be 'y'
drivers/usb/phy/Kconfig:34: depends on USB_GADGET || !USB_GADGET # if USB_GADGET=m, this can't be 'y'
drivers/usb/phy/Kconfig:57: depends on USB_GADGET || !USB_GADGET # if USB_GADGET=m, NOP can't be built-in
drivers/usb/phy/Kconfig:93: depends on USB_GADGET || !USB_GADGET # if USB_GADGET=m, this can't be 'y'
...

Thx.

--
Regards/Gruss,
Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.